New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert all SourceMapConsumers to TraceMaps #14253
Convert all SourceMapConsumers to TraceMaps #14253
Conversation
This accomplishes 2 goals: - Gets us off the ancient `source-map` v0.5.7 - Speeds up construction and tracing by ~10x.
37a3b17
to
7b0a467
Compare
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51221/ |
packages/babel-core/package.json
Outdated
"@types/convert-source-map": "^1.5.1", | ||
"@types/debug": "^4.1.0", | ||
"@types/resolve": "^1.3.2", | ||
"@types/semver": "^5.4.0", | ||
"@types/source-map": "^0.5.0", | ||
"source-map": "0.6.1" | ||
"@types/source-map": "^0.5.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still require the typings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
@@ -26,6 +26,7 @@ | |||
"devDependencies": { | |||
"@babel/helper-fixtures": "workspace:^", | |||
"@babel/parser": "workspace:^", | |||
"@jridgewell/trace-mapping": "^0.3.4", | |||
"@types/jsesc": "^2.5.0", | |||
"@types/source-map": "^0.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generator
does, because it uses SourceMapGenerator
. trace-mapping
only offers a Consumer API.
Merging as-is. The e2e error is unrelated to this PR. |
This accomplishes 2 things: